chore: added changelog for 9793 (secp256r1 tx malleability) (backport #9796) #9798

mergify · 2021-07-28T01:44:23Z

This is an automatic backport of pull request #9796 done by Mergify.
Cherry-pick of ff85c1d has failed:

On branch mergify/bp/release/v0.43.x/pr-9796
Your branch is up to date with 'origin/release/v0.43.x'.

You are currently cherry-picking commit ff85c1de1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   crypto/keys/internal/ecdsa/privkey.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

@Mergifyio refresh will re-evaluate the rules
@Mergifyio rebase will rebase this PR on its base branch
@Mergifyio update will merge the base branch into this PR
@Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

look at your merge queues
generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

## Description Added missing changelog and updated a `p256Order` comment to remove misleading part. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit ff85c1d) # Conflicts: # CHANGELOG.md

orijbot · 2021-07-28T01:50:16Z

Visit https://dashboard.github.orijtech.com?pr=9798&repo=cosmos%2Fcosmos-sdk to see benchmark details.

amaury1093 · 2021-07-28T09:04:52Z

server/grpc/gogoreflection/fix_registration.go

@@ -85,7 +86,7 @@ func getFileDescriptor(filePath string) []byte {
 	if len(fd) != 0 {
 		return fd
 	}
-
+	// nolint: staticcheck


This is weird: in #9779 (the backport PR) I removed these nolints because the linter said they were unused. Now two PRs later, linter is shouting again...

It's not the 1st first we see linter errors on untouched files in PRs, I remember some of these happening on release/0.42.x too

OK, so:

if I don't put nolint, the error is: "proto.FileDescriptor is deprecated..."

if I put nolint, the error is " directive // nolint: staticcheck is unused for linter "staticcheck""

I reverted all unrelated files changed in #9779 to their master version. If lint doesn't pass, let's just use admin rights for now to force merge.

…osmos#9796) (cosmos#9798) * chore: added changelog for 9793 (secp256r1 tx malleability) (cosmos#9796) ## Description Added missing changelog and updated a `p256Order` comment to remove misleading part. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit ff85c1d) # Conflicts: # CHANGELOG.md * Fix merge conflicts * Re-fix changelog * revert fix_registration to what's on master * Revert all files to master Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Cory Levinson <[email protected]> Co-authored-by: Amaury M <[email protected]>

…osmos#9796) (cosmos#9798) * chore: added changelog for 9793 (secp256r1 tx malleability) (cosmos#9796) Added missing changelog and updated a `p256Order` comment to remove misleading part. --- *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit ff85c1d) * Fix merge conflicts * Re-fix changelog * revert fix_registration to what's on master * Revert all files to master Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Cory Levinson <[email protected]> Co-authored-by: Amaury M <[email protected]>

…osmos#9796) (cosmos#9798) * chore: added changelog for 9793 (secp256r1 tx malleability) (cosmos#9796) ## Description Added missing changelog and updated a `p256Order` comment to remove misleading part. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit ff85c1d) # Conflicts: # CHANGELOG.md * Fix merge conflicts * Re-fix changelog * revert fix_registration to what's on master * Revert all files to master Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Cory Levinson <[email protected]> Co-authored-by: Amaury M <[email protected]>

mergify bot requested review from aaronc and alexanderbez as code owners July 28, 2021 01:44

mergify bot added the conflicts label Jul 28, 2021

Fix merge conflicts

5b83cc4

clevinson removed the conflicts label Jul 28, 2021

amaury1093 added 2 commits July 28, 2021 10:58

Re-fix changelog

af9c990

revert fix_registration to what's on master

5eb98ee

amaury1093 reviewed Jul 28, 2021

View reviewed changes

amaury1093 mentioned this pull request Jul 28, 2021

chore: Changelog and Release Notes for 0.43.0-rc3 #9801

Merged

22 tasks

Revert all files to master

7dc723f

github-actions bot added the C:x/auth label Jul 28, 2021

amaury1093 approved these changes Jul 28, 2021

View reviewed changes

aaronc merged commit 3daccc9 into release/v0.43.x Jul 28, 2021

aaronc deleted the mergify/bp/release/v0.43.x/pr-9796 branch July 28, 2021 15:22

fedekunze mentioned this pull request Nov 14, 2021

all: cherry pick olympus mons tharsis/cosmos-sdk#1

Closed

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: added changelog for 9793 (secp256r1 tx malleability) (backport #9796) #9798

chore: added changelog for 9793 (secp256r1 tx malleability) (backport #9796) #9798

mergify bot commented Jul 28, 2021

orijbot commented Jul 28, 2021

amaury1093 Jul 28, 2021

amaury1093 Jul 28, 2021

amaury1093 Jul 28, 2021

chore: added changelog for 9793 (secp256r1 tx malleability) (backport #9796) #9798

chore: added changelog for 9793 (secp256r1 tx malleability) (backport #9796) #9798

Conversation

mergify bot commented Jul 28, 2021

orijbot commented Jul 28, 2021

amaury1093 Jul 28, 2021

Choose a reason for hiding this comment

amaury1093 Jul 28, 2021

Choose a reason for hiding this comment

amaury1093 Jul 28, 2021

Choose a reason for hiding this comment