Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update Denom regex to support more DID characters #9699

Merged
merged 11 commits into from
Sep 27, 2021
Merged

feat!: update Denom regex to support more DID characters #9699

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9f5fe1a
feat!: support DID method-specific-id regex in denoms
aaronc Jul 1, 2021
2828ea2
Merge branch 'master' of github.com:cosmos/cosmos-sdk into aaronc/iid…
aaronc Jul 14, 2021
fade5c3
udpate docs
aaronc Jul 14, 2021
0d3eac5
add test case
aaronc Jul 14, 2021
8843993
update CHANGELOG.md
aaronc Jul 19, 2021
7b50921
Merge branch 'master' into aaronc/iid-denom-regex
aaronc Jul 19, 2021
0f95ea2
Merge branch 'master' into aaronc/iid-denom-regex
aaronc Jul 22, 2021
093a11c
Merge branch 'master' of github.com:cosmos/cosmos-sdk into aaronc/iid…
aaronc Sep 27, 2021
021fa86
fix CHANGELOG.md
aaronc Sep 27, 2021
d801934
fix test
aaronc Sep 27, 2021
bb3cd64
fix test
aaronc Sep 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions types/coin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,8 +633,8 @@ func (coins Coins) Sort() Coins {

var (
// Denominations can be 3 ~ 128 characters long and support letters, followed by either
// a letter, a number or a separator ('/').
reDnmString = `[a-zA-Z][a-zA-Z0-9/-]{2,127}`
// a letter, a number or a separator ('/', ':', '.', '_' or '-').
reDnmString = `[a-zA-Z][a-zA-Z0-9/:._-]{2,127}`
reDecAmt = `[[:digit:]]+(?:\.[[:digit:]]+)?|\.[[:digit:]]+`
reSpc = `[[:space:]]*`
reDnm *regexp.Regexp
Expand Down
1 change: 1 addition & 0 deletions types/coin_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ func (s *coinTestSuite) TestCoinIsValid() {
{sdk.Coin{loremIpsum, sdk.OneInt()}, false},
{sdk.Coin{"ibc/7F1D3FCF4AE79E1554D670D1AD949A9BA4E4A3C76C63093E17E446A46061A7A2", sdk.OneInt()}, true},
{sdk.Coin{"atOm", sdk.OneInt()}, true},
{sdk.Coin{"x:y-z.1_2", sdk.OneInt()}, true},
{sdk.Coin{" ", sdk.OneInt()}, false},
}

Expand Down