Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(rosetta): add Rosetta documentation page #9688

Merged
merged 14 commits into from
Jul 29, 2021
Merged

Conversation

noandrea
Copy link
Contributor

@noandrea noandrea commented Jul 13, 2021

Description

Closes: #9575

Add Rosetta documentation


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct docs: prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the documentation writing guidelines
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct docs: prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR only changes documentation
  • reviewed content for consistency
  • reviewed content for thoroughness
  • reviewed content for spelling and grammar
  • tested instructions (if applicable)

@noandrea noandrea requested a review from jgimeno July 13, 2021 13:03
@jgimeno jgimeno marked this pull request as ready for review July 14, 2021 08:54
@robert-zaremba
Copy link
Collaborator

Adding @anilcse as a reviewer - he was integrating Rosetta in our test net so just to verify if all information is there.

Copy link
Contributor

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions.

docs/rosetta/README.md Outdated Show resolved Hide resolved
docs/rosetta/README.md Outdated Show resolved Hide resolved
docs/rosetta/README.md Outdated Show resolved Hide resolved
docs/rosetta/README.md Outdated Show resolved Hide resolved
docs/rosetta/README.md Outdated Show resolved Hide resolved
docs/rosetta/README.md Outdated Show resolved Hide resolved
docs/rosetta/README.md Outdated Show resolved Hide resolved
docs/rosetta/README.md Outdated Show resolved Hide resolved
docs/rosetta/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we add app.toml settings as well? Might be useful for people who are migrating from old versions

jgimeno and others added 10 commits July 21, 2021 09:18
Co-authored-by: Ryan Christoffersen <[email protected]>
Co-authored-by: Ryan Christoffersen <[email protected]>
Co-authored-by: Ryan Christoffersen <[email protected]>
Co-authored-by: Ryan Christoffersen <[email protected]>
Co-authored-by: Ryan Christoffersen <[email protected]>
Co-authored-by: Ryan Christoffersen <[email protected]>
Co-authored-by: Ryan Christoffersen <[email protected]>
Co-authored-by: Ryan Christoffersen <[email protected]>
Co-authored-by: Ryan Christoffersen <[email protected]>
@orijbot
Copy link

orijbot commented Jul 21, 2021

Visit https://dashboard.github.orijtech.com?pr=9688&repo=cosmos%2Fcosmos-sdk to see benchmark details.

@jgimeno
Copy link
Contributor

jgimeno commented Jul 21, 2021

LGTM. Can we add app.toml settings as well? Might be useful for people who are migrating from old versions

If I am not mistaken the config via toml was not included in the last version. @fdymylja

@ryanchristo
Copy link
Contributor

Looking good! The location is a bit problematic.

The current location of this document is in the root level and it's not accessible using the sidebar.

Screenshot from 2021-07-27 10-54-53

This should merged with the existing rosetta documentation in the run-nodes directory.

Screenshot from 2021-07-27 10-57-57

@ryanchristo ryanchristo self-assigned this Jul 27, 2021
@robert-zaremba
Copy link
Collaborator

@ryanchristo - could you push the updates yourself and merge?

@ryanchristo ryanchristo force-pushed the docs/gh9575-rosetta branch from a8dae8c to 3d69152 Compare July 29, 2021 01:06
@ryanchristo ryanchristo added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 29, 2021
@ryanchristo ryanchristo merged commit 4eaf18a into master Jul 29, 2021
@ryanchristo ryanchristo deleted the docs/gh9575-rosetta branch July 29, 2021 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rosetta: more user guide and troubleshooting
7 participants