Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ADR-038 Part 3: State change files auxiliary gRPC server #9647

Closed
wants to merge 46 commits into from

Conversation

i-norden
Copy link
Contributor

@i-norden i-norden commented Jul 7, 2021

Description

Closes: #XXXX
On top of: #8664
Tentatively completes ADR-038

This currently relies on a fork of fsnotify that supports IN_CLOSE_WRITE events, which is only supported on linux. Another approach could be to use https://github.com/radovskyb/watcher (at least in the case where linux OS is not detected), but it is much less performant as it relies on file system polling. fsnotify also does not work with NFS.

Still need to:

  • Finish writing tests
  • Figure out cross-platform support as mentioned above
  • Update/provide documentation

Potentially want to:

This PR introduces an auxiliary service for reading the state change files written in #8664 and serving their data over gRPC interfaces.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

…g returned KVStores with the new ListenKVStore
@github-actions github-actions bot added the T: ADR An issue or PR relating to an architectural decision record label Jul 7, 2021
@i-norden i-norden force-pushed the adr038_auxserver branch 3 times, most recently from aa0a2d3 to 9ff16ee Compare July 8, 2021 04:50
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 23, 2021
@github-actions github-actions bot closed this Aug 30, 2021
@i-norden i-norden mentioned this pull request Sep 7, 2021
11 tasks
@robert-zaremba
Copy link
Collaborator

reopening - this is still good to include in the SDK.

@robert-zaremba
Copy link
Collaborator

Once we will have plugin interfaces merged will we need to modify here anything? It should work straight away, right?

@tac0turtle
Copy link
Member

@i-norden is it okay to close this then reopen once other prs land?

@tac0turtle
Copy link
Member

closing this for now. When plugin work lands we can reopen.

@tac0turtle tac0turtle closed this Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: ADR An issue or PR relating to an architectural decision record
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants