-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ADR-038 Part 3: State change files auxiliary gRPC server #9647
Conversation
…g returned KVStores with the new ListenKVStore
… from running 'make proto-gen'
…the BaseApp logger level
… KVPairs by store key
aa0a2d3
to
9ff16ee
Compare
9ff16ee
to
2549cf0
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
reopening - this is still good to include in the SDK. |
Once we will have plugin interfaces merged will we need to modify here anything? It should work straight away, right? |
@i-norden is it okay to close this then reopen once other prs land? |
closing this for now. When plugin work lands we can reopen. |
Description
Closes: #XXXX
On top of: #8664
Tentatively completes ADR-038
This currently relies on a fork of fsnotify that supports
IN_CLOSE_WRITE
events, which is only supported on linux. Another approach could be to use https://github.com/radovskyb/watcher (at least in the case where linux OS is not detected), but it is much less performant as it relies on file system polling. fsnotify also does not work withNFS
.Still need to:
Potentially want to:
This PR introduces an auxiliary service for reading the state change files written in #8664 and serving their data over gRPC interfaces.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change