Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: query txs command adds output flag #9540

Merged
merged 3 commits into from
Jun 21, 2021
Merged

fix: query txs command adds output flag #9540

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b03dc48
Query txs command add output flag
chengwenxi Jun 18, 2021
b371b73
add changelog
chengwenxi Jun 18, 2021
a3b3a85
Merge branch 'master' into vincent-search-txs-flags
amaury1093 Jun 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions x/auth/client/cli/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,7 @@ $ %s query txs --%s 'message.sender=cosmos1...&message.action=withdraw_delegator
},
}

cmd.Flags().StringP(flags.FlagNode, "n", "tcp://localhost:26657", "Node to connect to")
chengwenxi marked this conversation as resolved.
Show resolved Hide resolved
cmd.Flags().String(flags.FlagKeyringBackend, flags.DefaultKeyringBackend, "Select keyring's backend (os|file|kwallet|pass|test)")
Copy link
Contributor

@amaury1093 amaury1093 Jun 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically speaking removing --keyring-backend is a client-breaking change, so should wait RC before getting merged.

However, I agree with @chengwenxi that this flag is non-sensical here, and I'm pretty sure no-one uses it. So I'm actually okay to merge this PR. Any strong opinions @robert-zaremba and @ryanchristo ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be safe to merge. Not sure how one would use it in this situation anyways.

flags.AddQueryFlagsToCmd(cmd)
cmd.Flags().Int(flags.FlagPage, rest.DefaultPage, "Query a specific page of paginated results")
cmd.Flags().Int(flags.FlagLimit, rest.DefaultLimit, "Query number of transactions results per page returned")
amaury1093 marked this conversation as resolved.
Show resolved Hide resolved
cmd.Flags().String(flagEvents, "", fmt.Sprintf("list of transaction events in the form of %s", eventFormat))
Expand Down