refactor(client): add client/Context.Codec and deprecate JSONCodec #9498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-zaremba
requested review from
aaronc,
amaury1093,
alexanderbez,
cyberbono3,
ryanchristo and
technicallyty
github-actions
bot
added
C:CLI
C:Keys
robert-zaremba
changed the title
robert-zaremba
changed the title
Codecov Report
@@ Coverage Diff @@
## master #9498 +/- ##
==========================================
- Coverage 60.55% 60.54% -0.02%
==========================================
Files 590 590
Lines 37288 37296 +8
==========================================
+ Hits 22578 22579 +1
- Misses 12763 12768 +5
- Partials 1947 1949 +2
|
robert-zaremba
changed the title
|
IMO this should be |
Co-authored-by: Amaury <[email protected]>
robert-zaremba
changed the title
robert-zaremba
changed the title
cyberbono3
approved these changes
Jun 11, 2021
robert-zaremba
added
the
A:automerge
|
again some random errors in CI... rerunning ... rerunning |
8 tasks
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
…osmos#9498) * chore(types): add sdk.Context.Codec and deprecate JSONCodec * Use clientContext.Codec rather than JSONCodec everywhere * update tests to use clientContext.Codec * added a note that EncodingConfig.Marshaler will be renamed to Codec * update changelog * fix tests to use clientCtx.WithCodec instead of WithJSONCodec * fix genutil build * Update simapp/params/encoding.go Co-authored-by: Amaury <[email protected]> Co-authored-by: Amaury <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #9490
Going towards v0.44 release cycle, we need to use
codec.Codecin theclient/contex.Contextobject. This deprecatesclient/contex.JSONCodec. To assure smooth transition we add ``client/contex.Codec: codec.Codec` in v0.43 release and use it everywhere in the SDK instead of JSONCodec.Moreover I added a note that
encCfg.Marshalershould be renamed toencCfg.Codec.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change