-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add script to validate gentxs #9486
Conversation
I believe we should add some documentation for this but not sure on a best place. Any suggestions @AmauryM @clevinson @robert-zaremba ? |
I think a |
Hey @anilcse any progress on the documentation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but a comment about go
installation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
@anilcse I wonder if it would be useful to verify gentx signatures inside the collect-gentxs
subcommand? I.e. verify signatures via the Go code we already have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
That's a good idea, I will look into it. May be we can drop this PR if we find a simple tweak there. |
Yeah that sounds good. I didn't get good time to look into the possibility of handling it via go code directly. I will spend sometime this week. |
Visit https://dashboard.github.orijtech.com?pr=9486&repo=cosmos%2Fcosmos-sdk to see benchmark details. |
Description
ref: #9304
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change