Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add script to validate gentxs #9486

Merged
merged 11 commits into from
Jul 27, 2021
Merged

chore: Add script to validate gentxs #9486

merged 11 commits into from
Jul 27, 2021

Conversation

anilcse
Copy link
Collaborator

@anilcse anilcse commented Jun 9, 2021

Description

ref: #9304


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@anilcse anilcse marked this pull request as ready for review June 14, 2021 15:15
@anilcse
Copy link
Collaborator Author

anilcse commented Jun 14, 2021

I believe we should add some documentation for this but not sure on a best place. Any suggestions @AmauryM @clevinson @robert-zaremba ?

@anilcse anilcse marked this pull request as draft June 14, 2021 18:25
@amaury1093
Copy link
Contributor

I believe we should add some documentation for this but not sure on a best place.

I think a scripts/README.md is fine for now.

@amaury1093
Copy link
Contributor

Hey @anilcse any progress on the documentation?

@anilcse anilcse marked this pull request as ready for review July 7, 2021 13:54
Copy link
Contributor

@ruhatch ruhatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but a comment about go installation

scripts/validate-gentxs.sh Outdated Show resolved Hide resolved
@anilcse anilcse changed the title Add script to validate gentxs chore: Add script to validate gentxs Jul 7, 2021
@anilcse anilcse requested a review from ruhatch July 8, 2021 04:09
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@anilcse I wonder if it would be useful to verify gentx signatures inside the collect-gentxs subcommand? I.e. verify signatures via the Go code we already have.

Copy link
Contributor

@ruhatch ruhatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anilcse
Copy link
Collaborator Author

anilcse commented Jul 8, 2021

lgtm.

@anilcse I wonder if it would be useful to verify gentx signatures inside the collect-gentxs subcommand? I.e. verify signatures via the Go code we already have.

That's a good idea, I will look into it. May be we can drop this PR if we find a simple tweak there.

@amaury1093
Copy link
Contributor

@anilcse any progress on this?

We can also merge this, it's still an improvement. And we can not close #9304 and add a follow-up to try to see if we can use Go code.

@anilcse
Copy link
Collaborator Author

anilcse commented Jul 27, 2021

@anilcse any progress on this?

We can also merge this, it's still an improvement. And we can not close #9304 and add a follow-up to try to see if we can use Go code.

Yeah that sounds good. I didn't get good time to look into the possibility of handling it via go code directly. I will spend sometime this week.

@orijbot
Copy link

orijbot commented Jul 27, 2021

Visit https://dashboard.github.orijtech.com?pr=9486&repo=cosmos%2Fcosmos-sdk to see benchmark details.

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 27, 2021
@mergify mergify bot merged commit 760bde3 into master Jul 27, 2021
@mergify mergify bot deleted the anil/gentx_script branch July 27, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants