Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: app wiring POC #9398

Closed
wants to merge 20 commits into from
Closed

DNM: app wiring POC #9398

wants to merge 20 commits into from

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented May 27, 2021

ref: #9182


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@aaronc aaronc changed the title feat: app wiring POC DNM: app wiring POC May 27, 2021
@github-actions github-actions bot added the T:Docs Changes and features related to documentation. label May 27, 2021
@lgtm-com
Copy link

lgtm-com bot commented May 27, 2021

This pull request introduces 1 alert when merging 66ce471 into cb66c99 - view on LGTM.com

new alerts:

  • 1 for Unreachable statement

@lgtm-com
Copy link

lgtm-com bot commented May 29, 2021

This pull request introduces 1 alert when merging ce46d86 into 917fb76 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to field

@lgtm-com
Copy link

lgtm-com bot commented May 29, 2021

This pull request introduces 1 alert when merging da9ea79 into 917fb76 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to field

@lgtm-com
Copy link

lgtm-com bot commented Jun 1, 2021

This pull request introduces 1 alert when merging b0a9347 into 2ae7875 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to field

@aaronc aaronc closed this Jul 9, 2021
@aleem1314 aleem1314 deleted the aaronc/wiring-poc branch July 9, 2021 15:45
@aleem1314 aleem1314 restored the aaronc/wiring-poc branch July 9, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/bank T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant