feat: add Dec.Float64() function #9382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
suggested changes
May 23, 2021
tac0turtle
reviewed
May 23, 2021
alexanderbez
approved these changes
May 23, 2021
|
@alexanderbez it seems like I need a maintainer approve for this to be merged(as I'm the first-time contributor), otherwise CI checks won't run. Do you know who else should approve it for this to be ready to merge? |
amaury1093
reviewed
May 25, 2021
Co-authored-by: Amaury <[email protected]>
Co-authored-by: Amaury <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #9382 +/- ##
==========================================
- Coverage 60.40% 60.40% -0.01%
==========================================
Files 589 589
Lines 37095 37100 +5
==========================================
+ Hits 22407 22410 +3
- Misses 12711 12712 +1
- Partials 1977 1978 +1
|
alexanderbez
added
the
A:automerge
|
@alexanderbez how does the automerge work here? Seems like it doesn't like 3 failed PR checks or maybe something more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #9379
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/) (there are no docs for similar functions, so I'm not sure if this is needed)godoccomments. (this function is kinda obvious, is it required?)Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes