feat: Non-zero Default Fees #9371

cyberbono3 · 2021-05-20T17:13:45Z

Description

closes: #9106

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

codecov · 2021-05-20T19:03:42Z

Codecov Report

Merging #9371 (d77b083) into master (bb61e28) will increase coverage by 0.00%.
The diff coverage is 37.50%.

@@           Coverage Diff           @@
##           master    #9371   +/-   ##
=======================================
  Coverage   60.66%   60.66%           
=======================================
  Files         588      588           
  Lines       37266    37273    +7     
=======================================
+ Hits        22607    22612    +5     
  Misses      12715    12715           
- Partials     1944     1946    +2

Impacted Files	Coverage Δ
server/config/config.go	`40.35% <0.00%> (-1.10%)`	⬇️
testutil/network/util.go	`69.72% <0.00%> (-1.31%)`	⬇️
types/errors/errors.go	`80.32% <ø> (ø)`
simapp/simd/cmd/root.go	`67.33% <100.00%> (+0.44%)`	⬆️
server/logger.go	`33.33% <0.00%> (+33.33%)`	⬆️

cyberbono3 · 2021-05-26T10:29:01Z

I tested 2 cases:

Set MinGasPrices = "" in app.toml

./build/simd start
Error: MinGasPrices must not be empty

Set MinGasPrices to "0" in app.toml

./build/simd start
1:14PM INF starting ABCI with Tendermint
panic: invalid minimum gas prices: invalid decimal coin expression: 0

Questions:

Should I test cases to check precedence rules with envVars, flags? I guess, Viper handles it automatically.
Since empty value for MinGasPrices in app.toml is not allowed, what should be the default value for MinGasPrices in this case?

server/start.go

server/util.go

amaury1093 · 2021-05-26T12:32:49Z

Should I test cases to check precedence rules with envVars, flags? I guess, Viper handles it automatically.

it would be useful to still test it.

Since empty value for MinGasPrices in app.toml is not allowed, what should be the default value for MinGasPrices in this case?

There shouldn't by any default value, the app should exit.

Co-authored-by: Amaury <[email protected]>

server/config/config.go

amaury1093

lgtm, but we should add a test

server/util.go

cyberbono3 · 2021-05-28T14:52:52Z

Error: No release type found in pull request title "Non-zero Default Fees ". Add a prefix to indicate what kind of release this pull request corresponds to (see https://www.conventionalcommits.org/). what kind of prefix should I add here?

tac0turtle

is this R4R

cyberbono3 · 2021-06-06T10:21:56Z

is this R4R

yes

amaury1093 · 2021-06-24T08:19:58Z

@cyberbono3 could you also fix the test?

robert-zaremba

Looks good. 2 not blocking small things (would be good to have it in this PR):

update error to wrap from errors package (as in the comment below)
update setup guide (docs)

server/config/config.go

cyberbono3 · 2021-06-24T11:52:25Z

Looks good. 2 not blocking small things (would be good to have it in this PR):

update error to wrap from errors package (as in the comment below)

update setup guide (docs)

what setup guide do you mean here?

cyberbono3 · 2021-06-24T11:59:43Z

@cyberbono3 could you also fix the test?

I fixed that.

amaury1093 · 2021-06-24T12:22:22Z

@cyberbono3 did you start debugging why test-rosetta and liveness-test fail?

Edit:

to fix liveness-test, we should probably add --minimum-gas-prices=something:

cosmossdk/simd-env testnet --v 4 -o . --starting-ip-address 192.168.10.2 --keyring-backend=test --minimum-gas-prices=0stake ; fi

cyberbono3 · 2021-06-24T14:37:39Z

@cyberbono3 did you start debugging why test-rosetta and liveness-test fail?

Edit:

to fix liveness-test, we should probably add --minimum-gas-prices=something:
cosmossdk/simd-env testnet --v 4 -o . --starting-ip-address 192.168.10.2 --keyring-backend=test --minimum-gas-prices=0stake ; fi

I ran this command cosmossdk/simd-env testnet --v 4 -o . --starting-ip-address 192.168.10.2 --keyring-backend=test --minimum-gas-prices=0stake

Can you give me some context how to fix rosetta-test and liveness, please?

test_rosetta_1  | waiting for rosetta instance to be up
test_rosetta_1  | Terminated
rosetta_test_rosetta_1 exited with code 143

Should I look for this error code code 143 in the codebase?

amaury1093 · 2021-06-24T15:17:45Z

Can you give me some context how to fix rosetta-test and liveness, please?

For liveness, as I pointed out above, try maybe adding cosmossdk/simd-env testnet --v 4 -o . --starting-ip-address 192.168.10.2 --keyring-backend=test --minimum-gas-prices=0stake ; fi in the Makefile in localnet-start

For rosetta, not 100% sure where we should define min-gas-prices. Are there more logs?

amaury1093 · 2021-06-24T15:25:55Z

Looking at the osmosis launch, they explicitly said leave it empty. Is there a way the app developer could override this functionality in order to make a better UX if need be?

~~Maybe we should put this as public:~~

cosmos-sdk/server/config/config.go

Line 15 in bb61e28

defaultMinGasPrices = ""

~~So that app devs can do serverconfig.DefaultMinGasPrices = "whatever" (e.g. even "0denom") and that'll be set by default in all nodes' app.toml. wdyt @marbar3778 ? (although it's a new global var)~~

edit: #9371 (comment) seems like a better solution, as it doesn't introduce a global var

robert-zaremba · 2021-06-24T15:49:39Z

what setup guide do you mean here?

There is a guide on how to run a node - let's add a line there that the min gas price must be correctly set (with an example).

robert-zaremba · 2021-06-24T21:02:39Z

Can you give me some context how to fix rosetta-test and liveness, please?

Maybe check with @noandrea about the Rosetta test. Not sure why it fails when we add the min fee check.

amaury1093 · 2021-06-25T09:02:15Z

simapp/simd/cmd/root.go

+	// Optionally allow the chain developer to overwrite the SDK's default
+	// server config.
+	srvCfg := serverconfig.DefaultConfig()
+	// The SDK's default minimum gas price is set to "" (empty value) inside
+	// app.toml. If left empty by validators, the node will halt on startup.
+	// However, the chain developer can set a default app.toml value for their
+	// validators here.
+	//
+	// In summary:
+	// - if you leave srvCfg.MinGasPrices = "", all validators MUST tweak their
+	//   own app.toml config,
+	// - if you set srvCfg.MinGasPrices non-empty, validators CAN tweak their
+	//   own app.toml to override, or use this default value.
+	//
+	// In simapp, we set the min gas prices to 0.
+	srvCfg.MinGasPrices = "0stake"


Had a chat with @aaronc last evening about this, we were looking around Viper.SetDefault, but this morning I noticed this new initAppConfig function introduced by @anilcse in #9550. And it seems to me like the perfect place for chain developers to set a default min gas price.

cc. @marbar3778

this is awesome!! We should add a note in the docs, that @anilcse added, that this is possible.

tac0turtle

Approval pending an addition to docs.

amaury1093

tACK.

Manual test:

set srvCfg.MinGasPrices = "10stake" in cmd/root.go, node runs correctly, all txs need a --fee
set srvCfg.MinGasPrices = "", got error: Error: set min gas price in app.toml or flag or env variable: error in app.toml when running the node
- node runs correctly if I edit app.toml manually

amaury1093 · 2021-06-25T10:41:08Z

tests pass, docs added, I believe all reviews were addressed... putting automerge on!

## Description  closes: #9106 --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer - [ ] Review `Codecov Report` in the comment section below once CI passes (cherry picked from commit 3fd376b) # Conflicts: # CHANGELOG.md # contrib/rosetta/node/data.tar.gz # docs/core/cli.md # server/util_test.go # simapp/simd/cmd/root.go

## Description  closes: cosmos#9106 --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer - [ ] Review `Codecov Report` in the comment section below once CI passes

draft

ef14cc8

cyberbono3 requested a review from amaury1093 May 20, 2021 17:14

add MinGasPrices check in interceptConfigs

c85f811

cyberbono3 force-pushed the cyberbono3/non-zero-default-fees branch from c5b8a52 to c85f811 Compare May 26, 2021 10:12

amaury1093 reviewed May 26, 2021

View reviewed changes

server/start.go Outdated Show resolved Hide resolved

server/util.go Outdated Show resolved Hide resolved

cyberbono3 and others added 3 commits May 27, 2021 04:58

Update server/start.go

34e7484

Co-authored-by: Amaury <[email protected]>

revert changes in interceptConfigs in server/util.go

57ed05c

implement config.ValidateBasic method and call it within startInProcess

2d0e734

tac0turtle reviewed May 27, 2021

View reviewed changes

server/config/config.go Outdated Show resolved Hide resolved

amaury1093 reviewed May 27, 2021

View reviewed changes

server/config/config.go Outdated Show resolved Hide resolved

server/config/config.go Outdated Show resolved Hide resolved

fix ValidateBasic

4ec4af0

cyberbono3 commented May 27, 2021

View reviewed changes

server/config/config.go Show resolved Hide resolved

run gofmt

e52ee4f

github-actions bot added the C:CLI label May 28, 2021

amaury1093 reviewed May 28, 2021

View reviewed changes

server/util.go Outdated Show resolved Hide resolved

minor fixes

04bf221

github-actions bot removed the C:CLI label May 28, 2021

cyberbono3 added 2 commits May 28, 2021 17:55

gofmt

59c615f

uncapitalize error string

345e531

tac0turtle changed the title ~~Non-zero Default Fees~~ fix: Non-zero Default Fees Jun 4, 2021

tac0turtle reviewed Jun 4, 2021

View reviewed changes

cyberbono3 marked this pull request as ready for review June 6, 2021 10:21

cyberbono3 requested a review from aaronc as a code owner June 6, 2021 10:21

draft TestStartCmdwithEmptyandNonEmptyMinGasPrices

1c6ea9c

cyberbono3 force-pushed the cyberbono3/non-zero-default-fees branch from 4ded361 to 1c6ea9c Compare June 9, 2021 17:05

robert-zaremba reviewed Jun 24, 2021

View reviewed changes

server/config/config.go Outdated Show resolved Hide resolved

cyberbono3 added 2 commits June 24, 2021 14:28

fix failed test

40eb4eb

apply robert suggestion

58d180c

amaury1093 added 2 commits June 25, 2021 10:57

Allow chain devs to set min gas prices

7694dbd

Merge branch 'master' into cyberbono3/non-zero-default-fees

aa9b055

amaury1093 reviewed Jun 25, 2021

View reviewed changes

tac0turtle approved these changes Jun 25, 2021

View reviewed changes

Add docs

81d7718

amaury1093 approved these changes Jun 25, 2021

View reviewed changes

make rosetta-data

d77b083

github-actions bot added the C:Rosetta Issues and PR related to Rosetta label Jun 25, 2021

amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 25, 2021

mergify bot merged commit 3fd376b into master Jun 25, 2021

mergify bot deleted the cyberbono3/non-zero-default-fees branch June 25, 2021 10:41

mergify bot mentioned this pull request Jun 25, 2021

feat: Non-zero Default Fees (backport #9371) #9582

Closed

noandrea mentioned this pull request Jun 25, 2021

Rosetta: more user guide and troubleshooting #9575

Closed

7 tasks

yun-yeo mentioned this pull request Jun 29, 2021

[Bump] sdk version to v0.43.0-rc0 terra-money/classic-core#507

Merged

8 tasks

amaury1093 mentioned this pull request Jul 2, 2021

fix: Don't error on startup if min-gas-price is empty #9621

Merged

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Non-zero Default Fees #9371

feat: Non-zero Default Fees #9371

cyberbono3 commented May 20, 2021 •

edited

Loading

codecov bot commented May 20, 2021 •

edited

Loading

cyberbono3 commented May 26, 2021 •

edited

Loading

amaury1093 commented May 26, 2021

amaury1093 left a comment

cyberbono3 commented May 28, 2021

tac0turtle left a comment

cyberbono3 commented Jun 6, 2021

amaury1093 commented Jun 24, 2021

robert-zaremba left a comment •

edited by cyberbono3

Loading

cyberbono3 commented Jun 24, 2021

cyberbono3 commented Jun 24, 2021

amaury1093 commented Jun 24, 2021 •

edited

Loading

cyberbono3 commented Jun 24, 2021

amaury1093 commented Jun 24, 2021 •

edited

Loading

amaury1093 commented Jun 24, 2021 •

edited

Loading

robert-zaremba commented Jun 24, 2021

robert-zaremba commented Jun 24, 2021

amaury1093 Jun 25, 2021

tac0turtle Jun 25, 2021 •

edited

Loading

tac0turtle left a comment

amaury1093 left a comment •

edited

Loading

amaury1093 commented Jun 25, 2021

feat: Non-zero Default Fees #9371

feat: Non-zero Default Fees #9371

Conversation

cyberbono3 commented May 20, 2021 • edited Loading

Description

codecov bot commented May 20, 2021 • edited Loading

Codecov Report

cyberbono3 commented May 26, 2021 • edited Loading

amaury1093 commented May 26, 2021

amaury1093 left a comment

Choose a reason for hiding this comment

cyberbono3 commented May 28, 2021

tac0turtle left a comment

Choose a reason for hiding this comment

cyberbono3 commented Jun 6, 2021

amaury1093 commented Jun 24, 2021

robert-zaremba left a comment • edited by cyberbono3 Loading

Choose a reason for hiding this comment

cyberbono3 commented Jun 24, 2021

cyberbono3 commented Jun 24, 2021

amaury1093 commented Jun 24, 2021 • edited Loading

cyberbono3 commented Jun 24, 2021

amaury1093 commented Jun 24, 2021 • edited Loading

amaury1093 commented Jun 24, 2021 • edited Loading

robert-zaremba commented Jun 24, 2021

robert-zaremba commented Jun 24, 2021

amaury1093 Jun 25, 2021

Choose a reason for hiding this comment

tac0turtle Jun 25, 2021 • edited Loading

Choose a reason for hiding this comment

tac0turtle left a comment

Choose a reason for hiding this comment

amaury1093 left a comment • edited Loading

Choose a reason for hiding this comment

amaury1093 commented Jun 25, 2021

cyberbono3 commented May 20, 2021 •

edited

Loading

codecov bot commented May 20, 2021 •

edited

Loading

cyberbono3 commented May 26, 2021 •

edited

Loading

robert-zaremba left a comment •

edited by cyberbono3

Loading

amaury1093 commented Jun 24, 2021 •

edited

Loading

amaury1093 commented Jun 24, 2021 •

edited

Loading

amaury1093 commented Jun 24, 2021 •

edited

Loading

tac0turtle Jun 25, 2021 •

edited

Loading

amaury1093 left a comment •

edited

Loading