Improve readability in handleQueryP2P #9205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
approved these changes
Apr 27, 2021
Codecov Report
@@ Coverage Diff @@
## master #9205 +/- ##
==========================================
- Coverage 60.06% 60.06% -0.01%
==========================================
Files 595 595
Lines 37353 37355 +2
==========================================
+ Hits 22436 22437 +1
Misses 12929 12929
- Partials 1988 1989 +1
|
|
@marbar3778 @AmauryM please note the changes in c760c4fa9..923c0f84d including the requested |
…ssary initialization
jeebster
force-pushed
the
jeebster/4965-handleQueryP2P-improve-readability
branch
from
923c0f8
to
9a92272
Compare
amaury1093
added
the
A:automerge
zakir-code
pushed a commit
to PundiAI/cosmos-sdk
that referenced
this pull request
Apr 14, 2022
* refactor(abci handleP2PQuery): improve readability via control flow * refactor(acbi handleQueryP2P): fix logic control flow to ensure early return * refactor(abci handleQueryP2P): move var declaration to prevent unnecessary initialization * support(CHANGELOG): add description for abci handleQueryP2P changes Co-authored-by: Marko <[email protected]> Co-authored-by: Amaury <[email protected]> (cherry picked from commit 6fbded9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #4965
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes