Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix show multisig query #9108

Merged
merged 4 commits into from
Apr 16, 2021
Merged

fix show multisig query #9108

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9dfe0b
fix show multisig query
atheeshp Apr 14, 2021
b8e2c93
add change log
atheeshp Apr 14, 2021
2463c8e
Update change log
atheeshp Apr 14, 2021
b3b9fb0
add test case for multisig show
atheeshp Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

* (gRPC) [\#9015](https://github.com/cosmos/cosmos-sdk/pull/9015) Fix invalid status code when accessing gRPC endpoints.
* [\#9026](https://github.com/cosmos/cosmos-sdk/pull/9026) Fixed the bug that caused the `gentx` command to fail for Ledger keys.
* [\#9108](https://github.com/cosmos/cosmos-sdk/pull/9108) Fixed the bug with querying multisig account, which is not showing threshold and public_keys.
atheeshp marked this conversation as resolved.
Show resolved Hide resolved

### Improvements

Expand Down
3 changes: 3 additions & 0 deletions client/keys/show.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ func runShowCmd(cmd *cobra.Command, args []string) (err error) {
if err != nil {
return fmt.Errorf("%s is not a valid name or address: %v", args[0], err)
}
if info.GetType() == keyring.TypeMulti {
info = keyring.NewMultiInfo(info.GetName(), info.GetPubKey())
}
} else {
pks := make([]cryptotypes.PubKey, len(args))
for i, keyref := range args {
Expand Down