doc secp256r1 #8899
doc secp256r1 #8899
Conversation
robert-zaremba
requested review from
clevinson,
amaury1093,
blushi,
cyberbono3 and
technicallyty
robert-zaremba
requested review from
aaronc,
alessio and
alexanderbez
as code owners
|
|
||
| A few notes on the `Keyring` methods: | ||
| - `secp256k1`, as implemented in the [SDK's `crypto/keys/secp256k1` package](https://github.com/cosmos/cosmos-sdk/blob/v0.42.1/crypto/keys/secp256k1/secp256k1.go). | ||
| - `secp256r1`, as implemented in the [SDK's `crypto/keys/secp256r1` package](https://github.com/cosmos/cosmos-sdk/blob/master/crypto/keys/secp256r1/pubkey.go), |
There was a problem hiding this comment.
I use a link to master, to allow an easy find when we will tag a new release.
Co-authored-by: Alessio Treglia <[email protected]>
There was a problem hiding this comment.
@robert-zaremba First, congratulations on this excellent well-written knowledge. In my fourth week learning about blockchain, I feel like I hit the jackpot reviewing this content. (Today I received my first Ledger wallet... I am in the early stages of learning). Second, I provided grammatical suggestions with the best intentions for technical accuracy and working to establish technical content standards.
Third, I hope to elevate more use of style and content standards. See Technical content style guidance where we are documenting our standards (work in progress). I hope that you find the details and supporting links helpful. Since this is my first PR review with your content, I'm interested in how well it is received. Let me know how I can do better!
Awesome grammar fixes and style improvements Co-authored-by: Barrie Byron <[email protected]>
Awesome grammar and style improvements. Co-authored-by: Barrie Byron <[email protected]> Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: Barrie Byron <[email protected]>
|
@barriebyron - thanks for an awesome suggestions and your English grammar guidance. The Cosmos documentation will improve a lot thanks to this. |
Co-authored-by: Amaury <[email protected]>
|
Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=522a462665f74d7da9114694aed8c163 |
|
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=b30b5fb6ee3b2c692c1cf02dbe0ea23d5543f060 |
I agree, let's use "and"
|
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=042994347cb275dadedd4800d9157533f55462a5 |
alessio
dismissed
barriebyron’s stale review
All suggestions were accepted. Thanks!
clevinson
added
the
A:automerge
|
@robert-zaremba I was out of office, sorry to miss your approval request. Good doc work, thank you |
Description
closes: #8800
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes