-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multisig LegacyAminoPubKey Amino marshaling #8841
Conversation
Would love to have @anilcse or @akhilkumarpilli try this manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK. Thanks @AmauryM
Tests are failing |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=b91d022a26816abda5e227484393e86d9e4dafdd |
Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=1b01694fd86a49ebb7fdbd9b532f3891 |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=9cef41afaec759ef2c8565e656dd35eb5f066ab8 |
…dk into am/multisig-import
Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=d9ffd024d5f843c2a5443d664a173d2b |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=7d19b8ea5888c26e55fcdc3b5df4071b6afb5134 |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=f46993f49d4f3d2e798e33fbd76221cb694e3d03 |
Codecov Report
@@ Coverage Diff @@
## master #8841 +/- ##
==========================================
+ Coverage 59.15% 59.17% +0.01%
==========================================
Files 570 571 +1
Lines 31770 31800 +30
==========================================
+ Hits 18793 18817 +24
- Misses 10776 10780 +4
- Partials 2201 2203 +2
|
Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=b9251bec879d451b802dccb625226b8b |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=d4d27e1c0c138d76ab3082ba8e380d4d26db050a |
* Use v034auth RegisterCrypto * Add custom amino for LegacyAminoPubKey * Fix registercrypto * Revert old PR * revert some genutil stuff * Add comment * Add changelog * Remove binary marshalling * Fix lint * Fix lint again * Fix lint, 3rd time's a charm * ignore wrong linter warning * Fix UnmarshalAmioJSON Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Alessio Treglia <[email protected]> Co-authored-by: Anil Kumar Kammari <[email protected]> (cherry picked from commit d4d27e1) # Conflicts: # CHANGELOG.md # x/auth/legacy/v040/migrate.go
(cherry picked from commit d4d27e1) closes: #8776 Co-authored-by: Amaury <[email protected]> Co-authored-by: Alessio Treglia <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Anil Kumar Kammari <[email protected]>
Description
revert: #8794 (that was a temporary workaround)
closes: #8776
PR description in
crypto/keys/multisig/amino.go
commentsTo test, I did:
cannot unmarshal string into Go value of type uint32
#8776simd migrate v0.40 <json_file>
account_number:"90"
has correct NON-EMPTY multisig field.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes