Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ci: revert cleanup action's upstream latest changes (#8834)" #8840

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 10, 2021

Upstream has fixed rokroskar/workflow-run-cleanup-action#16


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! CI seems broken though

@alessio
Copy link
Contributor Author

alessio commented Mar 10, 2021

cool! CI seems broken though

Yes, that seems due to the fact that no tests are actually running

@alessio alessio merged commit 2b685ee into master Mar 10, 2021
@alessio alessio deleted the alessio/revert-cleanup-action-urgent-fix branch March 10, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: This now fails where previously it was working.
3 participants