Rename InfoImporter -> LegacyInfoImporter #8739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid namespace clash with the InfoImporter interface that already exists in the v0.41 release series.
alessio
requested review from
sahith-narahari,
amaury1093,
fdymylja,
jgimeno,
tac0turtle and
robert-zaremba
tac0turtle
approved these changes
Mar 1, 2021
alessio
added
A:automerge
Codecov Report
@@ Coverage Diff @@
## master #8739 +/- ##
=======================================
Coverage 61.44% 61.44%
=======================================
Files 673 673
Lines 38361 38361
=======================================
Hits 23571 23571
Misses 12309 12309
Partials 2481 2481
|
robert-zaremba
approved these changes
Mar 1, 2021
fdymylja
approved these changes
Mar 1, 2021
|
@robert-zaremba there is one InfoImporter interface in the keyring package of 0.41. The interfaces' methods are different |
mergify bot
pushed a commit
that referenced
this pull request
Mar 1, 2021
Avoid namespace clash with the InfoImporter interface that already exists in the v0.41 release series. (cherry picked from commit 010eeef) # Conflicts: # client/keys/migrate.go # crypto/keyring/keyring.go
Ah, I was looking at master :palm_face: |
alessio
pushed a commit
that referenced
this pull request
Mar 2, 2021
Avoid namespace clash with the InfoImporter interface that already exists in the v0.41 release series.
alessio
pushed a commit
that referenced
this pull request
Mar 2, 2021
* crypto/keyring: fix offline keys migration (#8639) Fix `keys migrate` command (#8703) crypto/keyring: reinstate the InfoImporter interface InfoImporter is implemented by those Keyring implementations that support import of Info objects. Co-authored-by: Alessio Treglia <[email protected]> Co-authored-by: Jonathan Gimeno <[email protected]> Co-authored-by: Amaury <[email protected]> * refresh golangci-lint * Rename InfoImporter -> LegacyInfoImporter (#8739) Avoid namespace clash with the InfoImporter interface that already exists in the v0.41 release series. * Revert "refresh golangci-lint" This reverts commit 38e1349. Co-authored-by: SaReN <[email protected]> Co-authored-by: Jonathan Gimeno <[email protected]> Co-authored-by: Amaury <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid namespace clash with the InfoImporter interface
that already exists in the v0.41 release series.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes