Allow REST endpoint to query txs with multisig #8730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8730 +/- ##
==========================================
- Coverage 61.38% 61.38% -0.01%
==========================================
Files 671 671
Lines 38343 38346 +3
==========================================
+ Hits 23536 23537 +1
- Misses 12348 12349 +1
- Partials 2459 2460 +1
|
amaury1093
force-pushed
the
am/8679-legacy-msig
branch
2 times, most recently
from
68c4312
to
6b3fab5
Compare
amaury1093
requested review from
aaronc,
alessio and
alexanderbez
as code owners
amaury1093
requested review from
robert-zaremba,
sahith-narahari,
fdymylja and
jgimeno
…sdk into am/8679-legacy-msig
jgimeno
approved these changes
Mar 1, 2021
|
@AmauryM tests are failing :-/ |
mergify bot
pushed a commit
that referenced
this pull request
Mar 1, 2021
* Fix unpack stdtx * Add test for multisig * remove println * Add changelog * Better UnpackInterfaces Co-authored-by: Alessio Treglia <[email protected]> (cherry picked from commit 3832860) # Conflicts: # CHANGELOG.md
|
Are we going to backport this to stargate ? |
This -> #8731 👍 |
alessio
pushed a commit
that referenced
this pull request
Mar 1, 2021
(cherry picked from commit 3832860) From: #8730 Co-authored-by: Alessio Treglia <[email protected]> Co-authored-by: Amaury <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #8679
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes