Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update linter #8660

Merged
merged 4 commits into from
Feb 22, 2021
Merged

Update linter #8660

merged 4 commits into from
Feb 22, 2021

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Feb 22, 2021

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@alessio alessio added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 22, 2021
amaury1093
amaury1093 approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge if CI passes

@alessio alessio merged commit 39b816e into master Feb 22, 2021
@alessio alessio deleted the update-linter branch February 22, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

@sahith-narahari sahith-narahari sahith-narahari approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@fedekunze fedekunze fedekunze approved these changes

@fdymylja fdymylja fdymylja approved these changes

@jgimeno jgimeno Awaiting requested review from jgimeno

@aaronc aaronc Awaiting requested review from aaronc

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alessio @amaury1093 @sahith-narahari @tac0turtle @fedekunze @fdymylja