Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add mention to use gRPC v1.33.2 #8658

Merged
merged 3 commits into from
Feb 25, 2021
Merged

docs: Add mention to use gRPC v1.33.2 #8658

merged 3 commits into from
Feb 25, 2021

Conversation

amaury1093
Copy link
Contributor

Description

ref: #8392 (comment)

closes: #8426

I added this warning in 3 places.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@amaury1093 amaury1093 added T:Docs Changes and features related to documentation. C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. backport/0.41.x (Stargate) labels Feb 22, 2021
@amaury1093 amaury1093 mentioned this pull request Feb 22, 2021
Closed
4 tasks
@amaury1093 amaury1093 requested a review from clevinson February 22, 2021 10:49
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 22, 2021
@amaury1093 amaury1093 mentioned this pull request Feb 24, 2021
Closed
4 tasks
@tac0turtle tac0turtle merged commit eeb3eab into master Feb 25, 2021
@tac0turtle tac0turtle deleted the am/grpc-docs branch February 25, 2021 07:57
mergify bot pushed a commit that referenced this pull request Feb 25, 2021
@amaury1093
docs: Add mention to use gRPC v1.33.2 (#8658)
edbbde7 
Co-authored-by: Marko <[email protected]>
(cherry picked from commit eeb3eab)
@mergify mergify bot mentioned this pull request Feb 25, 2021
Merged
alessio pushed a commit that referenced this pull request Feb 25, 2021
@mergify @amaury1093
docs: Add mention to use gRPC v1.33.2 (#8658) (#8699)
e766410 
Co-authored-by: Marko <[email protected]>
(cherry picked from commit eeb3eab)

Co-authored-by: Amaury <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alessio alessio Awaiting requested review from alessio

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@clevinson clevinson Awaiting requested review from clevinson

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

query error about mint module
2 participants
@amaury1093 @tac0turtle