cosmovisor: set larger buffer size for cosmovisor to scan log (fix #8651) #8653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allthatjazzleo
requested review from
aaronc,
alessio and
alexanderbez
as code owners
anilcse
reviewed
Feb 21, 2021
cosmovisor/scanner.go
Outdated
| @@ -27,6 +27,10 @@ type UpgradeInfo struct { | |||
| // It returns (nil, err) if the input stream errored | |||
| // It returns (nil, nil) if the input closed without ever matching the regexp | |||
| func WaitForUpdate(scanner *bufio.Scanner) (*UpgradeInfo, error) { | |||
| // set larger buffer in case the line is too long, the default one is 64*1024 | |||
| const maxCapacity = 512 * 1024 | |||
There was a problem hiding this comment.
How about making it a ENV setting?
There was a problem hiding this comment.
It could work - as long as sane defaults are provided 👍
allthatjazzleo
force-pushed
the
cosmovisor_bufio_size
branch
2 times, most recently
from
100a5dd to
3b6c892
Compare
allthatjazzleo
force-pushed
the
cosmovisor_bufio_size
branch
from
3b6c892 to
c471405
Compare
tac0turtle
approved these changes
Apr 14, 2021
anilcse
approved these changes
May 11, 2021
There was a problem hiding this comment.
lgtm.
@clevinson @robert-zaremba do we still need this as we are replacing it with file based approach in #8590
I do think we still want to switch to the file based approach. There are other security reasons to do so. |
|
@aaronc is this still going to be merged? |
aaronc
added
C:Cosmovisor
github-actions
bot
added
the
T:Docs
roysc
pushed a commit
to vulcanize/cosmos-sdk
that referenced
this pull request
Jun 23, 2021
…smos#8651) (cosmos#8653) * cosmovisor: set larger buffer for cosmovisor to scan log (fix cosmos#8651) * update cosmovisor README and set buffer size to ENV setting Co-authored-by: Marko <[email protected]> Co-authored-by: Aaron Craelius <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set larger buffer size for cosmovisor to scan log.
The default 64K is not enough and cosmovisor can be stuck.
closes: #8651
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes