-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/multistore: revert a height limit increase from #8396 #8466
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8466 +/- ##
=======================================
Coverage 61.47% 61.47%
=======================================
Files 630 630
Lines 36398 36398
=======================================
Hits 22377 22377
Misses 11671 11671
Partials 2350 2350
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @alessio!
Please update the PR title and commit title to something like: ‘store/multistore: revert a height limit increase from #8396‘ which provides better accountability and easy to trace down. Thank you. |
3b92368
to
6874114
Compare
store/multistore: revert a height limit increase from #8396 See #8396 (comment)
From: #8396 #8466 Thanks: @RiccardoM for the original patch.
See #8396 (comment)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes