Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/multistore: revert a height limit increase from #8396 #8466

Merged
merged 3 commits into from
Jan 29, 2021

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jan 28, 2021

See #8396 (comment)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #8466 (3b92368) into master (784a9a6) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8466   +/-   ##
=======================================
  Coverage   61.47%   61.47%           
=======================================
  Files         630      630           
  Lines       36398    36398           
=======================================
  Hits        22377    22377           
  Misses      11671    11671           
  Partials     2350     2350           
Impacted Files Coverage Δ
store/rootmulti/store.go 66.05% <0.00%> (ø)

Copy link
Collaborator

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @alessio!

@odeke-em
Copy link
Collaborator

Please update the PR title and commit title to something like: ‘store/multistore: revert a height limit increase from #8396‘ which provides better accountability and easy to trace down. Thank you.

@alessio alessio changed the title partially revert #8396 store/multistore: revert a height limit increase from #8396 Jan 28, 2021
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Jan 29, 2021
@mergify mergify bot merged commit 3b8e0f9 into master Jan 29, 2021
@mergify mergify bot deleted the alessio/followup-8396 branch January 29, 2021 18:46
alessio pushed a commit that referenced this pull request Feb 1, 2021
alessio pushed a commit that referenced this pull request Feb 17, 2021
store/multistore: revert a height limit increase from #8396

See #8396 (comment)
alessio pushed a commit that referenced this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants