[docs] x/crisis - general audit and cleanup #8269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
aleem1314
requested review from
aaronc,
alessio and
alexanderbez
as code owners
amaury1093
approved these changes
Jan 8, 2021
9 tasks
amaury1093
added
the
A:automerge
| InvariantRoute string | ||
| } | ||
| ``` | ||
| +++ https://github.com/cosmos/cosmos-sdk/blob/v0.40.0-rc7/proto/cosmos/crisis/v1beta1/tx.proto#L14-L22 |
There was a problem hiding this comment.
Wouldn't it be nice for the messages doc to have the generated msg types, also is there a reason to prefer links over using proto messages directly
There was a problem hiding this comment.
FYI such links should just render as code samples on https://docs.cosmos.network/
There was a problem hiding this comment.
I agree it's slightly harder to read the raw md file, but I also believe it's less error-prone and easier to maintain.
There was a problem hiding this comment.
yeah I see where you're coming from, was just concerned about the readability when using github directly.
atheeshp
approved these changes
Jan 11, 2021
aleem1314
added a commit
that referenced
this pull request
Jan 12, 2021
* update docs * review changes Co-authored-by: atheeshp <[email protected]>
aleem1314
added a commit
that referenced
this pull request
Jan 28, 2021
* update docs * review changes Co-authored-by: atheeshp <[email protected]>
clevinson
added
backports/0.41.x (Stargate)
and removed
backport/0.40.x (Stargate)
labels
This was referenced Feb 10, 2021
Closed
alessio
pushed a commit
that referenced
this pull request
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #7659
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes