Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version --long displays replaced build dependencies #7943

Merged

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Nov 16, 2020

From: #7941
Closes: #7940


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #7943 (ce8bab1) into launchpad/backports (1bbffff) will not change coverage.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##           launchpad/backports    #7943   +/-   ##
====================================================
  Coverage                50.27%   50.27%           
====================================================
  Files                      338      338           
  Lines                    17560    17560           
====================================================
  Hits                      8828     8828           
  Misses                    7939     7939           
  Partials                   793      793           

@ethanfrey
Copy link
Contributor

Very useful

Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

Copy link
Contributor

@clevinson clevinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!

@clevinson clevinson merged commit 69f6ec2 into launchpad/backports Nov 19, 2020
@clevinson clevinson deleted the alessio-launchpad-show-replaced-build-deps branch November 19, 2020 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants