x/ibc/24-host: fix some comments and dedup a function #7923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebuchman
requested review from
aaronc,
alessio and
alexanderbez
as code owners
ebuchman
changed the title
Codecov Report
@@ Coverage Diff @@
## master #7923 +/- ##
==========================================
- Coverage 54.15% 54.15% -0.01%
==========================================
Files 612 612
Lines 38985 38980 -5
==========================================
- Hits 21114 21109 -5
Misses 15701 15701
Partials 2170 2170 |
fedekunze
added
x/ibc
A:automerge
colin-axner
approved these changes
Nov 13, 2020
| // PathValidator takes in path string and validates with default identifier rules: | ||
| // path consists of `/`-separated valid identifiers, | ||
| // each identifier is between 1-64 characters and contains only alphanumeric and some allowed | ||
| // special characters (see IsValidID). | ||
| func PathValidator(path string) error { |
There was a problem hiding this comment.
@fedekunze why do we have this function?
It seems to be only used in connection genesis validating ConnectionPaths but from what I can tell, a connection path is simply all the connection ids attached to a client id. Instead we should be calling connection id validation. I don't think there are any / in a connection path as we currently use them
There was a problem hiding this comment.
I can open a followup fixing this, here is where we use ConnectionPaths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor fixes to some comments. Also adds a suggested code dedup from https://github.com/cosmos/cosmos-sdk/issues/7922#issuecomment-726396387
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes