Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move sdk denom validation to top of ValidateIBCDenom #7917

Merged
merged 2 commits into from
Nov 12, 2020

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Nov 12, 2020

Description

closes: #7905


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #7917 (6a240d0) into master (96f239d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7917      +/-   ##
==========================================
- Coverage   54.18%   54.17%   -0.01%     
==========================================
  Files         612      612              
  Lines       38987    38989       +2     
==========================================
- Hits        21124    21122       -2     
- Misses      15696    15698       +2     
- Partials     2167     2169       +2     

@colin-axner colin-axner added the A:automerge Automatically merge PR once all prerequisites pass. label Nov 12, 2020
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@mergify mergify bot merged commit 956e1cf into master Nov 12, 2020
@mergify mergify bot deleted the colin/7905-validate-transfer-denom branch November 12, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

20-transfer: move sdk.ValidateDenom outside of the switch case
3 participants