-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve error messages for legacy rest endpoints #7856
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7856 +/- ##
==========================================
+ Coverage 54.14% 54.16% +0.01%
==========================================
Files 612 612
Lines 39029 39047 +18
==========================================
+ Hits 21134 21150 +16
- Misses 15720 15721 +1
- Partials 2175 2176 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a simple test to cover this?
…prove-error-handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall
…prove-error-handling
…prove-error-handling
ref: #7639
Description
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes