Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error messages for legacy rest endpoints #7856

Merged
merged 14 commits into from
Nov 17, 2020

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Nov 9, 2020

ref: #7639

Description


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #7856 (2d8a51b) into master (9369a00) will increase coverage by 0.01%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #7856      +/-   ##
==========================================
+ Coverage   54.14%   54.16%   +0.01%     
==========================================
  Files         612      612              
  Lines       39029    39047      +18     
==========================================
+ Hits        21134    21150      +16     
- Misses      15720    15721       +1     
- Partials     2175     2176       +1     

Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a simple test to cover this?

@atheeshp atheeshp marked this pull request as ready for review November 16, 2020 06:51
x/auth/client/rest/query.go Outdated Show resolved Hide resolved
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall

x/auth/client/rest/decode.go Outdated Show resolved Hide resolved
@atheeshp atheeshp requested a review from blushi November 17, 2020 08:58
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Nov 17, 2020
@mergify mergify bot merged commit ab71048 into master Nov 17, 2020
@mergify mergify bot deleted the atheesh/improve-error-handling branch November 17, 2020 14:46
@aaronc aaronc mentioned this pull request Nov 23, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants