ibc: client params allowlist #7855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
requested review from
aaronc,
alessio and
alexanderbez
as code owners
…osmos-sdk into fedekunze/7825-client-allowlist
Codecov Report
@@ Coverage Diff @@
## master #7855 +/- ##
==========================================
- Coverage 54.21% 54.18% -0.04%
==========================================
Files 610 612 +2
Lines 38868 38960 +92
==========================================
+ Hits 21071 21109 +38
- Misses 15639 15692 +53
- Partials 2158 2159 +1 |
cwgoes
suggested changes
Nov 10, 2020
colin-axner
reviewed
Nov 10, 2020
AdityaSripal
approved these changes
Nov 10, 2020
x/ibc/core/02-client/types/params.go
Outdated
|
|
||
| var ( | ||
| // DefaultAllowedClients are "Solo Machine" and "Tendermint" | ||
| DefaultAllowedClients = []string{"Solo Machine", "Tendermint"} |
There was a problem hiding this comment.
Should LocalHost be added as well?
There was a problem hiding this comment.
we could consider adding it and remove the CreateLocalhost boolean from GenesisState. Although I'd prefer to do that on another PR
colin-axner
approved these changes
Nov 11, 2020
fedekunze
added
A:automerge
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* ibc: client params allowlist * genesis and gRPC * client * lint * spec * fixes * validate localhost client * move client types back to exported * update genesis * sort clients by id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7825