unknownproto: check result from protowire.ConsumeFieldValue and return an error #7770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeke-em
requested review from
aaronc,
alessio and
alexanderbez
as code owners
…n error Given that protowire.ConsumeFieldValue returns -1 when it encounters an error, perform a check for n < 0 and return the respectively obtained error with context about the details. Fixes an issue identified from a go-fuzz session, thanks to Ethan Buchman and the IBC auditors from Informal Systems et al. Fixes #7739.
odeke-em
force-pushed
the
unknownproto-catch-errors-from-protowire.ConsumeFieldValue
branch
from
b247fca to
b915e8d
Compare
Codecov Report
@@ Coverage Diff @@
## master #7770 +/- ##
=======================================
Coverage 54.19% 54.20%
=======================================
Files 610 610
Lines 38811 38815 +4
=======================================
+ Hits 21035 21039 +4
Misses 15621 15621
Partials 2155 2155 |
alexanderbez
previously requested changes
Nov 1, 2020
odeke-em
force-pushed
the
unknownproto-catch-errors-from-protowire.ConsumeFieldValue
branch
from
1af0c86 to
4499515
Compare
amaury1093
reviewed
Nov 4, 2020
amaury1093
approved these changes
Nov 5, 2020
4 tasks
|
All done, thanks for the reviews @robert-zaremba @amaurymartiny, addressed! Please help me with the final review/merge. Thank you! |
robert-zaremba
added
the
A:automerge
|
@alexanderbez could you please take a look? Robert approved and added the automerge label but it perhaps needs another code owner to approve. Thank you! |
mergify
bot
deleted the
unknownproto-catch-errors-from-protowire.ConsumeFieldValue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that protowire.ConsumeFieldValue returns -1 when it encounters an
error, perform a check for n < 0 and return the respectively obtained
error with context about the details.
Fixes an issue identified from a go-fuzz session, thanks to Ethan
Buchman and the IBC auditors from Informal Systems et al.
Fixes #7739.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes