Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]: update building modules section to reflect ADR31 #7702

Merged
merged 64 commits into from
Nov 17, 2020

Conversation

blushi
Copy link
Contributor

@blushi blushi commented Oct 28, 2020

Description

closes: #7660


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #7702 (fdc22e7) into master (03c8fb3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7702   +/-   ##
=======================================
  Coverage   54.17%   54.17%           
=======================================
  Files         612      612           
  Lines       39047    39047           
=======================================
  Hits        21153    21153           
  Misses      15719    15719           
  Partials     2175     2175           

Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added few suggestions

docs/building-modules/handler.md Outdated Show resolved Hide resolved
docs/building-modules/handler.md Outdated Show resolved Hide resolved
docs/building-modules/handler.md Outdated Show resolved Hide resolved
docs/building-modules/handler.md Outdated Show resolved Hide resolved
docs/building-modules/handler.md Outdated Show resolved Hide resolved
docs/building-modules/handler.md Outdated Show resolved Hide resolved
docs/building-modules/handler.md Outdated Show resolved Hide resolved
docs/building-modules/messages-and-queries.md Outdated Show resolved Hide resolved
@blushi blushi requested a review from aaronc October 29, 2020 10:08
blushi and others added 21 commits November 13, 2020 08:52
Co-authored-by: Aaron Craelius <[email protected]>
Co-authored-by: Aaron Craelius <[email protected]>
Co-authored-by: Aaron Craelius <[email protected]>
@amaury1093
Copy link
Contributor

Shouldn't we just link to local code in the repo?

Created #7929

@clevinson clevinson dismissed aaronc’s stale review November 17, 2020 19:24

most issues addressed & linking to local code tackled in #7929

@clevinson clevinson added the A:automerge Automatically merge PR once all prerequisites pass. label Nov 17, 2020
@mergify mergify bot merged commit 1cc8af8 into master Nov 17, 2020
@mergify mergify bot deleted the marie/7660-building-modules branch November 17, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs]: update building modules section to reflect ADR31
5 participants