post-upgrade with x/upgrade queries not working #7531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit bbbc0e1)
RiccardoM
requested review from
alessio,
alexanderbez,
fedekunze and
jackzampolin
as code owners
Codecov Report
@@ Coverage Diff @@
## launchpad/backports #7531 +/- ##
======================================================
Coverage ? 50.26%
======================================================
Files ? 338
Lines ? 17560
Branches ? 0
======================================================
Hits ? 8827
Misses ? 7940
Partials ? 793 |
|
|
alessio
changed the base branch from
okwme/v0.39.1-target
to
launchpad/backports
|
Updated base branch accordingly. Please resolve the conflicts. |
alessio
suggested changes
Oct 14, 2020
…to v0.39.1-upgrade-fix � Conflicts: � types/coin_benchmark_test.go
ethanfrey
approved these changes
Oct 15, 2020
| // LoadStore returns an IAVL Store as a CommitKVStore setting its initialVersion | ||
| // to the one given. Internally, it will load the store's version (id) from the | ||
| // provided DB. An error is returned if the version fails to load. | ||
| func LoadStoreWithInitialVersion(db dbm.DB, id types.CommitID, lazyLoading bool, initialVersion uint64) (types.CommitKVStore, error) { |
There was a problem hiding this comment.
This is a very nice function.
| // been pruned, an error will be returned. Any mutable operations executed will | ||
| // result in a panic. | ||
| // been pruned, an empty immutable IAVL tree will be used. | ||
| // Any mutable operations executed will result in a panic. |
There was a problem hiding this comment.
I wonder why the behavior here needs to change? Ah, for the historical queries once the new, empty store is created.
alessio
reviewed
Oct 15, 2020
alessio
reviewed
Oct 15, 2020
alessio
reviewed
Oct 15, 2020
alessio
reviewed
Oct 15, 2020
alessio
approved these changes
Oct 15, 2020
|
@clevinson please review and provide approval |
ethanfrey
approved these changes
Oct 15, 2020
clevinson
approved these changes
Oct 15, 2020
Co-authored-by: Cory <[email protected]>
Co-authored-by: Cory <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #7415 for Cosmos v0.39.2.
Closes the already closed #7385
Note
There was no base branch to compare with for Cosmos v0.39.1, so I picked this one. Please let me know if I should change it.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes