Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade followup #3 #7467

Merged
merged 2 commits into from
Oct 7, 2020
Merged

Upgrade followup #3 #7467

merged 2 commits into from
Oct 7, 2020

Conversation

AdityaSripal
Copy link
Member

Description

Prevent upgrades to an expired client. Fixes bug caught by @colin-axner

Final followup to #7367


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@AdityaSripal AdityaSripal marked this pull request as ready for review October 6, 2020 18:51
@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@3e6089d). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #7467   +/-   ##
=========================================
  Coverage          ?   56.22%           
=========================================
  Files             ?      457           
  Lines             ?    27214           
  Branches          ?        0           
=========================================
  Hits              ?    15302           
  Misses            ?    10238           
  Partials          ?     1674           

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thanks!

@cwgoes cwgoes added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 7, 2020
@mergify mergify bot merged commit bb6b0cf into master Oct 7, 2020
@mergify mergify bot deleted the aditya/upgrade-followup-3 branch October 7, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants