ibc: protobuf v1 #7432
ibc: protobuf v1 #7432
Conversation
fedekunze
requested review from
aaronc,
alessio and
alexanderbez
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7432 +/- ##
==========================================
- Coverage 55.17% 55.07% -0.11%
==========================================
Files 435 588 +153
Lines 28783 36760 +7977
==========================================
+ Hits 15881 20245 +4364
- Misses 11302 14417 +3115
- Partials 1600 2098 +498 |
|
we need to update these too right? |
|
@colin-axner @amaurymartiny updated the codec too 👍 |
| @@ -11,11 +11,11 @@ import ( | |||
| // Any. | |||
| func RegisterInterfaces(registry codectypes.InterfaceRegistry) { | |||
| registry.RegisterInterface( | |||
| "cosmos_sdk.ibc.v1.connection.ConnectionI", | |||
| "ibc.core.connection.v1.ConnectionI", | |||
There was a problem hiding this comment.
not sure if we should rename this to just Connection instead of ConnectionI
There was a problem hiding this comment.
I'd be fine renaming. exported.Connection should imply it is an interface
There was a problem hiding this comment.
though ideally we would do this with all interfaces since it seems the channel has the same format
fedekunze
added
the
A:automerge
|
could we wait to merge 🙏 I don't want conflicts stacking up on my handshake pr. The connection handshake changes should be r4r |
| @@ -9,19 +9,19 @@ import ( | |||
| // RegisterInterfaces registers the commitment interfaces to protobuf Any. | |||
| func RegisterInterfaces(registry codectypes.InterfaceRegistry) { | |||
| registry.RegisterInterface( | |||
| "cosmos.ibc.commitment.Root", | |||
| "ibc.core.commitment.v1.Root", | |||
Ah sorry, I didn't check the automerge label. Should we revert this? @fedekunze |
closes #7338