Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update launchpad docs to build without failing #7412

Merged
merged 2 commits into from
Sep 30, 2020

Conversation

clevinson
Copy link
Contributor

@clevinson clevinson commented Sep 30, 2020

As a prerequisite for having multiple versions of docs deployed on docs.cosmos.network, we need launchpad docs to compile properly.

Currently when building from the launchpad/backports branch, docs failed to compile. This fixes that by updating themeConfig in .vuepress/config.json as well as updating the package.json for docs to pull from the most recent cosmos vuepress theme.

Unblocks #7413

ref #6953


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Sep 30, 2020
Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this, but I can ensure this has no negative effects on the go code. If these docs work better for deployment, then I give a 👍

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. Approved.

@alessio alessio merged commit 203876e into launchpad/backports Sep 30, 2020
@alessio alessio deleted the clevinson/launchpad-docs-site branch September 30, 2020 10:31
@alessio alessio added this to the 0.39.2 - The Launchpad Series milestone Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants