Update 99designs/keyring to v1.1.6 for go 1.15 #7397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release contains a fix for dvsekhvalnov/jose2go#26, which is needed for the file keyring backend to work with go 1.15.
Dominator008
requested review from
aaronc,
alessio and
alexanderbez
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7397 +/- ##
==========================================
+ Coverage 55.35% 55.47% +0.11%
==========================================
Files 587 436 -151
Lines 36469 28503 -7966
==========================================
- Hits 20189 15812 -4377
+ Misses 14192 11096 -3096
+ Partials 2088 1595 -493 |
alessio
approved these changes
Sep 25, 2020
|
Targeting Launchpad as well. Thanks! |
alessio
pushed a commit
that referenced
this pull request
Sep 25, 2020
The release contains a fix for dvsekhvalnov/jose2go#26, which is needed for the file keyring backend to work with go 1.15. From: #7397
9 tasks
alessio
pushed a commit
that referenced
this pull request
Sep 28, 2020
The release contains a fix for dvsekhvalnov/jose2go#26, which is needed for the file keyring backend to work with go 1.15. From: #7397
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release contains a fix for dvsekhvalnov/jose2go#26,
which is needed for the file keyring backend to work with go 1.15.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes