Fix AfterImport and update black/white list variable namings #7159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
requested review from
aaronc,
alessio and
alexanderbez
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7159 +/- ##
==========================================
- Coverage 58.14% 54.53% -3.62%
==========================================
Files 412 566 +154
Lines 28281 38728 +10447
==========================================
+ Hits 16445 21120 +4675
- Misses 10525 15884 +5359
- Partials 1311 1724 +413 |
fedekunze
approved these changes
Aug 25, 2020
| @@ -255,10 +255,10 @@ func TestAppSimulationAfterImport(t *testing.T) { | |||
| _, _, err = simulation.SimulateFromSeed( | |||
| t, | |||
| os.Stdout, | |||
| app.BaseApp, | |||
| newApp.BaseApp, | |||
There was a problem hiding this comment.
ahh copy paste. Sorry about that
fedekunze
reviewed
Aug 25, 2020
server/export.go
Outdated
Comment on lines
21
to
23
| flagHeight = "height" | ||
| flagForZeroHeight = "for-zero-height" | ||
| flagJailAllowedAddrs = "jail-allowed-addrs" |
There was a problem hiding this comment.
actually, can we make these flags public?
There was a problem hiding this comment.
I'm not sure what that means. feel free to push to this branch
amaury1093
approved these changes
Aug 25, 2020
alexanderbez
approved these changes
Aug 25, 2020
alexanderbez
added
the
A:automerge
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
…7159) * fix sim bug and rename remaining references of black/white list * make server export command flags public * make missed flag public Co-authored-by: Federico Kunze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should fix
AfterImportsim.newApphad gotten changed toappin #7135. While looking at the diffs I realized I missed some black/white list naming references so I thought it'd be fine to update those in this pr as well.The failing seed passed for me locally but we should wait for the full sim to run
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes