ADR 029: Fee Grant Module #7106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7106 +/- ##
==========================================
- Coverage 56.02% 54.61% -1.41%
==========================================
Files 591 547 -44
Lines 37177 37132 -45
==========================================
- Hits 20827 20280 -547
- Misses 14232 15194 +962
+ Partials 2118 1658 -460 |
aaronc
requested review from
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
aaronc
added
the
T: ADR
amaury1093
reviewed
Oct 5, 2020
blushi
approved these changes
Oct 7, 2020
|
Could one of you take a quick look @alexanderbez @alessio ? Would be good to get an ACK from outside our team before merging this in. (At least that's my general sense for how we're approaching ADRs) |
…ronc/adr-fee-grant
alessio
approved these changes
Oct 9, 2020
|
I'm going to go ahead and merge this. If people have follow-up comments that didn't get addressed here we can discuss in separate PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for post-Stargate work, feel free to ignore until after we cut an RC.
ref: #7074
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes