ADR 030: Authorization Module #7105
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7105 +/- ##
==========================================
- Coverage 61.91% 54.60% -7.31%
==========================================
Files 609 547 -62
Lines 35101 37121 +2020
==========================================
- Hits 21732 20270 -1462
- Misses 11085 15192 +4107
+ Partials 2284 1659 -625
|
clevinson
added
the
T: ADR
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
aaronc
requested review from
amaury1093,
anilcse,
atheeshp,
blushi,
clevinson and
robert-zaremba
|
@alessio didn't mean to dismiss your approval - I was trying re-request reviews from our team. Can you re-approve? (Feel free to review the minor changes, but really not much has changed). |
|
Can you re-review @robert-zaremba ? You have changes requested still. |
| ## Changelog | ||
|
|
||
| - 2019-11-06: Initial Draft | ||
| - 2020-10-12: Updated Draft |
There was a problem hiding this comment.
let's update a changelog - it's accepted now.
| // by this authorization and will be updated as tokens are spent. If it is | ||
| // empty, there is no spend limit and any amount of coins can be spent. | ||
| SpendLimit sdk.Coins | ||
| } |
There was a problem hiding this comment.
It would make sense to add an account which is allowed to spend the coins. We can add it in pseudocode or a comment.
There was a problem hiding this comment.
Can you explain a little more what you mean?
There was a problem hiding this comment.
I was just thinking about having a more complete example, were we don't authorize everyone to spend from an account, but only one specific user.
| // ExecAuthorized attempts to execute the provided messages using | ||
| // authorizations granted to the grantee. Each message should have only | ||
| // one signer corresponding to the granter of the authorization. | ||
| rpc ExecAuthorized(MsgExecAuthorized) returns (MsgExecAuthorizedResponse) |
There was a problem hiding this comment.
Could you specify how this method will call other services? Let's use the SendAuthorization example. Will x/authz have clients to all other modules? How it will inform other module that a message is authorized?
I thought that DispatchActions will do that. But it seams that the DispatchActions is used for other modules to call x/authz.
There was a problem hiding this comment.
I think we addressed this when we chatted right?
There was a problem hiding this comment.
yes, I can add more details in other PR.
Co-authored-by: Robert Zaremba <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
ref: #7074
replaces #5235
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes