Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launchpad: backport BigInt fix #7087

Merged
merged 5 commits into from
Aug 20, 2020
Merged

Conversation

fedekunze
Copy link
Collaborator

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@fedekunze fedekunze marked this pull request as ready for review August 18, 2020 15:28
@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

❗ No coverage uploaded for pull request base (launchpad/backports@86f953b). Click here to learn what that means.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##             launchpad/backports    #7087   +/-   ##
======================================================
  Coverage                       ?   51.52%           
======================================================
  Files                          ?      338           
  Lines                          ?    20594           
  Branches                       ?        0           
======================================================
  Hits                           ?    10611           
  Misses                         ?     9188           
  Partials                       ?      795           

@alessio alessio added this to the 0.39.2 - The Launchpad Series milestone Aug 18, 2020
CHANGELOG.md Outdated Show resolved Hide resolved
@alessio alessio requested review from clevinson and ethanfrey August 18, 2020 16:45
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK'd

Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing panics is always good 👍

Copy link
Contributor

@clevinson clevinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@alessio alessio merged commit 4d3afea into launchpad/backports Aug 20, 2020
@alessio alessio deleted the cherry-pick-BigInt branch August 20, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants