Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose ADR 027: Deterministic Protobuf Serialization #6979

Merged
merged 14 commits into from
Aug 19, 2020
Merged

Propose ADR 027: Deterministic Protobuf Serialization #6979

merged 14 commits into from
Aug 19, 2020

Commits on Aug 19, 2020

  1. Add ADR 026: Protocol Buffer Regencode

    @webmaster128
    webmaster128 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    f1d13bb View commit details
    Browse the repository at this point in the history

  2. Use Regencode in ADR-020

    @webmaster128
    webmaster128 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    71d8198 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Aaron Craelius <[email protected]>
    @webmaster128 @aaronc
    webmaster128 and aaronc committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    1615050 View commit details
    Browse the repository at this point in the history

  4. Add reasoning behind omitting empty fields

    @webmaster128
    webmaster128 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    04aeca9 View commit details
    Browse the repository at this point in the history

  5. Rename to ADR 026: Deterministic Protobuf Serialization

    @webmaster128
    webmaster128 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    fb3a2fa View commit details
    Browse the repository at this point in the history

  6. i++

    @webmaster128
    webmaster128 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    2ce2021 View commit details
    Browse the repository at this point in the history

  7. explicitely -> explicitly

    @webmaster128
    webmaster128 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    93d5b04 View commit details
    Browse the repository at this point in the history

  8. Fix description of optional values

    @webmaster128
    webmaster128 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    390b4cd View commit details
    Browse the repository at this point in the history

  9. Update reasoning behind omitting default values

    @webmaster128
    webmaster128 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    b3ceacd View commit details
    Browse the repository at this point in the history

  10. Fix empty -> defaut

    @webmaster128
    webmaster128 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    a814331 View commit details
    Browse the repository at this point in the history

  11. Update docs/architecture/adr-027-deterministic-protobuf-serialization.md 

    Co-authored-by: Amaury Martiny <[email protected]>
    @webmaster128 @amaury1093
    webmaster128 and amaury1093 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    8568d7c View commit details
    Browse the repository at this point in the history

  12. Add rules to avoid duplicate encoding and specify packed fields

    @webmaster128
    webmaster128 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    f389d31 View commit details
    Browse the repository at this point in the history

  13. Add rule for variant encoding

    @webmaster128
    webmaster128 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    0ad5600 View commit details
    Browse the repository at this point in the history

  14. Add surrogate pair to test UTF-8 encoding

    @webmaster128
    webmaster128 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    7299e7f View commit details
    Browse the repository at this point in the history