Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nil check bug #6895

Merged
merged 1 commit into from
Jul 30, 2020
Merged

fix nil check bug #6895

merged 1 commit into from
Jul 30, 2020

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Jul 30, 2020

Description

saw this during review of #6471

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #6895 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #6895   +/-   ##
=======================================
  Coverage   61.65%   61.65%           
=======================================
  Files         511      511           
  Lines       31883    31883           
=======================================
  Hits        19657    19657           
  Misses      10672    10672           
  Partials     1554     1554           

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@fedekunze fedekunze merged commit fe6a341 into master Jul 30, 2020
@fedekunze fedekunze deleted the colin/commitment-bug-fix branch July 30, 2020 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants