Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/ibc-transfer: ADR001 source tracing implementation #6871

Merged
merged 54 commits into from
Aug 14, 2020

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Jul 28, 2020

Description

implements #6662


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@fedekunze fedekunze added this to the IBC 1.0 milestone Aug 3, 2020
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #6871 into master will increase coverage by 8.03%.
The diff coverage is 42.43%.

@@            Coverage Diff             @@
##           master    #6871      +/-   ##
==========================================
+ Coverage   46.77%   54.80%   +8.03%     
==========================================
  Files         237      535     +298     
  Lines       17460    36475   +19015     
==========================================
+ Hits         8167    19991   +11824     
- Misses       8641    14847    +6206     
- Partials      652     1637     +985     

types/coin.go Outdated Show resolved Hide resolved
x/ibc-transfer/keeper/relay.go Outdated Show resolved Hide resolved
@fedekunze fedekunze mentioned this pull request Aug 12, 2020
9 tasks
@fedekunze fedekunze marked this pull request as draft August 14, 2020 09:37
Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some remaining nits left

x/ibc-transfer/types/trace.go Outdated Show resolved Hide resolved
@fedekunze fedekunze marked this pull request as ready for review August 14, 2020 20:56
@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 14, 2020
@fedekunze fedekunze merged commit 3022fe9 into master Aug 14, 2020
@fedekunze fedekunze deleted the fedekunze/adr-001-implementation branch August 14, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants