Start removing HybridCodec (init + auth, bank, distribution) #6838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6838 +/- ##
==========================================
+ Coverage 55.96% 61.42% +5.46%
==========================================
Files 224 508 +284
Lines 14203 31467 +17264
==========================================
+ Hits 7948 19329 +11381
- Misses 5674 10637 +4963
- Partials 581 1501 +920 |
aaronc
changed the title
aaronc
added
A:automerge
aaronc
requested review from
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
fedekunze
approved these changes
Jul 24, 2020
| ret0, _ := ret[0].(types0.Querier) | ||
| return ret0 | ||
| } | ||
|
|
||
| // NewQuerierHandler indicates an expected call of NewQuerierHandler | ||
| // LegacyQuerierHandler indicates an expected call of LegacyQuerierHandler |
There was a problem hiding this comment.
doc is not consistent with the function name
alexanderbez
approved these changes
Jul 24, 2020
| @@ -10,24 +10,24 @@ import ( | |||
| ) | |||
|
|
|||
| // NewQuerier creates a querier for auth REST endpoints | |||
| func NewQuerier(k AccountKeeper) sdk.Querier { | |||
| func NewQuerier(k AccountKeeper, cdc codec.JSONMarshaler) sdk.Querier { | |||
There was a problem hiding this comment.
Should we be consistent with the parameter naming?
Suggested change
| func NewQuerier(k AccountKeeper, cdc codec.JSONMarshaler) sdk.Querier { | |
| func NewQuerier(k AccountKeeper, legacyQuerierCdc codec.JSONMarshaler) sdk.Querier { |
| func (am AppModule) NewQuerierHandler() sdk.Querier { | ||
| return keeper.NewQuerier(am.accountKeeper) | ||
| // LegacyQuerierHandler returns the auth module sdk.Querier. | ||
| func (am AppModule) LegacyQuerierHandler(jsonCdc codec.JSONMarshaler) sdk.Querier { |
There was a problem hiding this comment.
Suggested change
| func (am AppModule) LegacyQuerierHandler(jsonCdc codec.JSONMarshaler) sdk.Querier { | |
| func (am AppModule) LegacyQuerierHandler(legacyQuerierCdc codec.JSONMarshaler) sdk.Querier { |
|
Ohhh well automerged...would be nice to address these in a followup PR then @aaronc |
We cannot @fedekunze -- we've already proposed and agreed that we're keeping the legacy API around for 1 release to allow clients enough time to migrate to the new gRPC and/or gRPC HTTP gateway. |
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
…6838) * Start to remove HybridCodec * Rename * Fixes * Test fixes * Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #6837
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes