Context: Remove Init/New #6797
Merged
Context: Remove Init/New #6797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6797 +/- ##
==========================================
- Coverage 60.80% 60.44% -0.37%
==========================================
Files 510 514 +4
Lines 31523 31635 +112
==========================================
- Hits 19168 19121 -47
- Misses 10883 11048 +165
+ Partials 1472 1466 -6 |
alexanderbez
added
A:automerge
4 tasks
alexanderbez
commented
Jul 20, 2020
| @@ -142,6 +142,8 @@ func interceptConfigs(ctx *Context, rootViper *viper.Viper) (*tmcfg.Config, erro | |||
| } | |||
| } | |||
|
|
|||
| conf.SetRoot(rootDir) | |||
There was a problem hiding this comment.
/cc @jgimeno - This fixes the issue you were seeing.
alexanderbez
requested review from
aaronc,
alessio,
clevinson,
fedekunze and
jgimeno
as code owners
alexanderbez
commented
Jul 20, 2020
| @@ -56,126 +51,6 @@ type Context struct { | |||
| Codec *codec.Codec | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This makes me so happy ^__^
fedekunze
approved these changes
Jul 20, 2020
chengwenxi
pushed a commit
to irisnet/cosmos-sdk
that referenced
this pull request
Jul 22, 2020
* init commit * remove new/init functions * update CLI commands * tests: fix TestCLIQueryConn * remove viper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New*andInit*client.Contextfunctions ❤️ ❤️ ❤️ ❤️ref: #6571
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes