Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/bank/simulation/operations.go: add unit tests #6771

Merged
merged 6 commits into from
Jul 18, 2020

Conversation

dauTT
Copy link
Contributor

@dauTT dauTT commented Jul 18, 2020

Description

closes a sub-task related to issue #5007


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 18, 2020

Codecov Report

Merging #6771 into master will increase coverage by 0.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6771      +/-   ##
==========================================
+ Coverage   59.89%   60.31%   +0.41%     
==========================================
  Files         513      513              
  Lines       31491    31491              
==========================================
+ Hits        18861    18993     +132     
+ Misses      11192    11048     -144     
- Partials     1438     1450      +12     

@dauTT dauTT mentioned this pull request Jul 18, 2020
8 tasks
x/bank/simulation/operations_test.go Outdated Show resolved Hide resolved
x/bank/simulation/operations_test.go Outdated Show resolved Hide resolved
@alexanderbez alexanderbez merged commit 13b5a8d into cosmos:master Jul 18, 2020
@dauTT dauTT deleted the bank-sim-test-operations-5007 branch July 19, 2020 09:17
chengwenxi pushed a commit to irisnet/cosmos-sdk that referenced this pull request Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants