Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/ibc: CLI Remove Viper #6608

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jul 6, 2020

Description

ref: #6571


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@alexanderbez alexanderbez added C:CLI x/ibc Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. A:automerge Automatically merge PR once all prerequisites pass. labels Jul 6, 2020
@alexanderbez alexanderbez mentioned this pull request Jul 6, 2020
27 tasks
@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #6608 into master will decrease coverage by 0.78%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6608      +/-   ##
==========================================
- Coverage   57.68%   56.90%   -0.79%     
==========================================
  Files         369      485     +116     
  Lines       23482    29165    +5683     
==========================================
+ Hits        13546    16595    +3049     
- Misses       8987    11382    +2395     
- Partials      949     1188     +239     

@alexanderbez alexanderbez merged commit fd9cdb8 into master Jul 6, 2020
@alexanderbez alexanderbez deleted the bez/6571-viper-removal-cli-ibc branch July 6, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants