Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove alias.go from 05-port #6575

Merged
merged 1 commit into from
Jul 2, 2020
Merged

remove alias.go from 05-port #6575

merged 1 commit into from
Jul 2, 2020

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Jul 2, 2020

Description

ref: #6311


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@colin-axner
Copy link
Contributor Author

I think this is the lest reference of alias.go 🎉

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #6575 into master will not change coverage.
The diff coverage is 25.00%.

@@           Coverage Diff           @@
##           master    #6575   +/-   ##
=======================================
  Coverage   56.84%   56.84%           
=======================================
  Files         481      481           
  Lines       28921    28921           
=======================================
  Hits        16441    16441           
  Misses      11314    11314           
  Partials     1166     1166           

@colin-axner colin-axner added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 2, 2020
@tac0turtle
Copy link
Member

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jul 2, 2020

Command refresh: success

@mergify mergify bot merged commit 8ed09e5 into master Jul 2, 2020
@mergify mergify bot deleted the colin/6311-remove-alias-ibc branch July 2, 2020 12:44
@aaronc
Copy link
Member

aaronc commented Jul 2, 2020

It appears this PR introduced a bug in integration tests. @colin-axner could you take a look?

@tac0turtle
Copy link
Member

tac0turtle commented Jul 2, 2020

#6582 (comment)

I don't think it was from this PR. This was known side effect when we merged a previous pr that @alexanderbez did, right?

#6525 (comment)

@colin-axner
Copy link
Contributor Author

colin-axner commented Jul 2, 2020

maybe there was a fix and this wasn't merged with master?

I don't see how this could have introduced anything since it is just import alias changing

@aaronc
Copy link
Member

aaronc commented Jul 2, 2020

Maybe it was introduced earlier but this is the first commit where I see integration tests failing again. Anyway @alexanderbez is looking into it.

larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants