Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove alias.go from 03-connection #6543

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Jun 30, 2020

Description

ref: #6311


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #6543 into master will not change coverage.
The diff coverage is 83.67%.

@@           Coverage Diff           @@
##           master    #6543   +/-   ##
=======================================
  Coverage   56.85%   56.85%           
=======================================
  Files         479      479           
  Lines       28796    28796           
=======================================
  Hits        16371    16371           
  Misses      11268    11268           
  Partials     1157     1157           

@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 30, 2020
@fedekunze fedekunze merged commit e8fb76a into master Jun 30, 2020
@fedekunze fedekunze deleted the colin/6311-remove-alias-connection branch June 30, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants