-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export validator addresses #6529
Merged
alexanderbez
merged 3 commits into
cosmos:master
from
agoric-labs:mfig/export-validator-address
Jun 29, 2020
Merged
Export validator addresses #6529
alexanderbez
merged 3 commits into
cosmos:master
from
agoric-labs:mfig/export-validator-address
Jun 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
June 28, 2020 18:27
michaelfig
force-pushed
the
mfig/export-validator-address
branch
from
June 28, 2020 18:30
f309f5d
to
4d82af4
Compare
Codecov Report
@@ Coverage Diff @@
## master #6529 +/- ##
==========================================
+ Coverage 56.78% 56.81% +0.03%
==========================================
Files 478 478
Lines 28745 28746 +1
==========================================
+ Hits 16322 16333 +11
+ Misses 11277 11267 -10
Partials 1146 1146 |
alexanderbez
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
alexanderbez
added
R4R
A:automerge
Automatically merge PR once all prerequisites pass.
C:x/staking
labels
Jun 29, 2020
alessio
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nihil obstat
michaelfig
force-pushed
the
mfig/export-validator-address
branch
from
June 29, 2020 17:30
4d82af4
to
c19769d
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One-liner to export validator addresses properly.
closes: #6528
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer