Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export validator addresses #6529

Merged
merged 3 commits into from
Jun 29, 2020

Conversation

michaelfig
Copy link
Contributor

@michaelfig michaelfig commented Jun 28, 2020

Description

One-liner to export validator addresses properly.

closes: #6528


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@michaelfig michaelfig changed the title Mfig/export validator address Export validator addresses Jun 28, 2020
@michaelfig michaelfig force-pushed the mfig/export-validator-address branch from f309f5d to 4d82af4 Compare June 28, 2020 18:30
@codecov
Copy link

codecov bot commented Jun 28, 2020

Codecov Report

Merging #6529 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6529      +/-   ##
==========================================
+ Coverage   56.78%   56.81%   +0.03%     
==========================================
  Files         478      478              
  Lines       28745    28746       +1     
==========================================
+ Hits        16322    16333      +11     
+ Misses      11277    11267      -10     
  Partials     1146     1146              

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@alexanderbez alexanderbez added R4R A:automerge Automatically merge PR once all prerequisites pass. C:x/staking labels Jun 29, 2020
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nihil obstat

@michaelfig michaelfig force-pushed the mfig/export-validator-address branch from 4d82af4 to c19769d Compare June 29, 2020 17:30
@alexanderbez alexanderbez merged commit 6251d28 into cosmos:master Jun 29, 2020
@michaelfig michaelfig deleted the mfig/export-validator-address branch June 29, 2020 18:56
@ethanfrey ethanfrey mentioned this pull request Jun 30, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/staking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validator set addresses need to be exported
3 participants