Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: fix iavl revision #6492

Merged
merged 1 commit into from
Jun 23, 2020
Merged

deps: fix iavl revision #6492

merged 1 commit into from
Jun 23, 2020

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Jun 23, 2020

Description

closes: #6486


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@fedekunze fedekunze added dependencies Pull requests that update a dependency file R4R labels Jun 23, 2020
@@ -37,7 +37,7 @@ require (
github.com/tendermint/btcd v0.1.1
github.com/tendermint/crypto v0.0.0-20191022145703-50d29ede1e15
github.com/tendermint/go-amino v0.15.1
github.com/tendermint/iavl v0.13.4-0.20200621145059-83c3470ad61d
github.com/tendermint/iavl v0.13.4-0.20200622140716-a41a83e2415f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
github.com/tendermint/iavl v0.13.4-0.20200622140716-a41a83e2415f
github.com/cosmos/iavl v0.13.4-0.20200622140716-a41a83e2415f

Then go mod verify and go mod tidy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the go.mod in iavl has not migrated to cosmos/iavl. We should do this in the next major release of IAVL

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go: github.com/cosmos/[email protected]: parsing go.mod:
	module declares its path as: github.com/tendermint/iavl
	        but was required as: github.com/cosmos/iavl

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #6492 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6492   +/-   ##
=======================================
  Coverage   56.34%   56.34%           
=======================================
  Files         470      470           
  Lines       28232    28232           
=======================================
  Hits        15907    15907           
  Misses      11200    11200           
  Partials     1125     1125           

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@fedekunze fedekunze merged commit ac83fce into master Jun 23, 2020
@fedekunze fedekunze deleted the fix-iavl-revision branch June 23, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot can't resolve your Go dependency files
4 participants