Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling and grammar #6480

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Spelling and grammar #6480

merged 1 commit into from
Jun 22, 2020

Conversation

okwme
Copy link
Contributor

@okwme okwme commented Jun 22, 2020

Minimal changes

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@okwme
Spelling and grammar
f6b66bf 
Minimal changes
@fedekunze
Copy link
Collaborator

thanks @okwme. I'm improving the IBC docs on #6472. Feel free to add or comment if something is missing in your opinion

alexanderbez
alexanderbez approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexanderbez alexanderbez added T:Docs Changes and features related to documentation. R4R labels Jun 22, 2020
@fedekunze fedekunze merged commit 6700d77 into master Jun 22, 2020
@fedekunze fedekunze deleted the okwme-patch-1 branch June 22, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alessio alessio Awaiting requested review from alessio

@clevinson clevinson Awaiting requested review from clevinson

@fedekunze fedekunze Awaiting requested review from fedekunze

@jgimeno jgimeno Awaiting requested review from jgimeno

Assignees
No one assigned
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@okwme @fedekunze @alexanderbez